From 0105e0d46ea1f774c56c8f6e75b0e9f55fc2fc7e Mon Sep 17 00:00:00 2001 From: Christoph Brandau Date: Sun, 5 Jul 2026 23:20:28 +0200 Subject: [PATCH] feat(cicd): collect only expected artifact bundle files Artifact collection previously grabbed every file under each bundle directory, which could include unrelated or intermediate outputs. This updates the logic to only include files with the expected extensions for each artifact type, improving accuracy and reducing noise. - Use a per-bundle suffix map to filter collected artifacts - Switch to non-recursive directory iteration for bundle roots --- cicd_tool/main.py | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/cicd_tool/main.py b/cicd_tool/main.py index 9e03d81..9ebb4ef 100644 --- a/cicd_tool/main.py +++ b/cicd_tool/main.py @@ -115,16 +115,21 @@ def _ensure_bucket(client: Minio, bucket_name: str) -> None: def _collect_artifacts() -> List[Path]: artifacts: List[Path] = [] - for directory in ( - ARTIFACT_ROOT / "msi", - ARTIFACT_ROOT / "nsis", - ARTIFACT_ROOT / "appimage", - ARTIFACT_ROOT / "deb", - ARTIFACT_ROOT / "rpm", - ARTIFACT_ROOT / "app", - ): + bundle_dirs = { + ARTIFACT_ROOT / "msi": (".msi", ".sig"), + ARTIFACT_ROOT / "nsis": (".exe", ".sig"), + ARTIFACT_ROOT / "appimage": (".appimage", ".sig"), + ARTIFACT_ROOT / "deb": (".deb", ".sig"), + ARTIFACT_ROOT / "rpm": (".rpm", ".sig"), + ARTIFACT_ROOT / "app": (".dmg", ".zip", ".sig"), + } + for directory, suffixes in bundle_dirs.items(): if directory.exists(): - artifacts.extend(p for p in directory.rglob("*") if p.is_file()) + artifacts.extend( + p + for p in directory.iterdir() + if p.is_file() and p.suffix.lower() in suffixes + ) return artifacts