Support automatic branch cleanup and merge-method selection for reviews #51

Merged
Christoph merged 3 commits from enhance_issue_center into main 2026-09-18 13:25:25 +00:00
3 Commits
Author SHA1 Message Date
Christoph 5db4f36abf feat(integrations): support automatic branch cleanup after merge
Add a new git::review_cleanup module that implements a CleanupPlan with
prepare() and finish() routines to safely remove/clean tracking and local
branches after a PR/MR is merged. The cleanup logic validates branch names,
ensures a clean worktree, checks remotes/URLs, verifies commits/ancestry,
protects against concurrent worktrees or divergent local/remote commits, and
performs authenticated fetch/push and ref updates. Unit tests for the cleanup
behavior are included.

Wire provider-side cleanup into integrations:
- add an integrations/cleanup module to read provider PR payloads and derive
  cleanup inputs
- run cleanup::prepare(...) before performing a merge when an optional
  cleanup_path is provided
- after a successful provider merge, run cleanup::finish(...); any failure is
  reported as MERGE_ACCEPTED_CLEANUP_FAILED

Also:
- export the new git review_cleanup module (src-tauri/src/git.rs)
- accept an optional cleanup_path parameter in run_integration_review_action
- remove the previous REVIEW_REQUEST_TIMEOUT wrapper around the spawned
  blocking task (the integration action is no longer wrapped with the 35s timeout)
2026-09-18 15:22:57 +02:00
Christoph 6a40159f9f feat(integrations): add merge-method selection and provider-specific payloads
Introduce dedicated merge handling for integration review merges:

- Add src-tauri/src/integrations/merge.rs: implements merge_options (read provider repo settings), merge_payload (build provider-specific merge body) and a Tauri command get_integration_review_merge_options. Includes unit tests for behavior.
- Wire merge module into integrations.rs and pass an optional merge_method into provider-specific review action functions (GitHub, GitLab, Gitea, Azure DevOps). run_integration_review_action now accepts an optional merge_method, validates it early, and includes provider-specific merge payloads when performing a merge.
- Export the new command in src-tauri/src/main.rs so the frontend can request merge options.

Frontend changes to support selecting a merge method before merging:

- ConfirmDialog.svelte: add SelectMenu support and a select field to confirm requests.
- ReviewCenter.svelte: fetch integration merge options, show a merge-method selector in the merge confirmation, and pass the chosen method to the review action.
- Update types and git bindings to surface IntegrationMergeOptions / IntegrationMergeMethod and the getIntegrationReviewMergeOptions call (git.ts / types.ts changes staged).

Effect: users can pick a merge method appropriate to the provider/project; the integration layer generates the correct API payload per provider. Tests added for merge logic.
2026-09-18 15:12:25 +02:00
Christoph ed484f5477 feat(components): make CommentEditor configurable and use it for description
Replace the plain textarea in CreateReviewDialog with CommentEditor bound to
the description. The dialog now passes language, disabled, rows, ariaLabel,
previewLabel and placeholder so the description field gains markdown preview
and consistent accessible labels/placeholders.

Make CommentEditor props optional and configurable:
- onSend is now (() => void | Promise<void>) | undefined; Enter/Cmd+Enter and
  the send button are guarded/hidden when onSend is not provided.
- Add placeholder, ariaLabel, previewLabel and rows (default 5) to allow
  parent components to control appearance and accessibility.

Also add a small documentation tweak in commit_ai's cloud template: remind
authors to keep the title plain text and expand guidance on Markdown formatting.
2026-09-18 12:53:43 +02:00